Skip to content

Conversation

@emmi-odoo
Copy link
Contributor

task-4946924

@robodoo
Copy link
Collaborator

robodoo commented Oct 6, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team October 6, 2025 12:12
@emmi-odoo emmi-odoo force-pushed the saas-18.4-pos-payment-methods-emmi branch from d391b1e to 049b780 Compare October 6, 2025 14:44
@emmi-odoo emmi-odoo requested a review from a team October 6, 2025 15:03
@emmi-odoo emmi-odoo force-pushed the saas-18.4-pos-payment-methods-emmi branch from 049b780 to 3db7ff4 Compare October 7, 2025 07:16
@emmi-odoo emmi-odoo changed the title [IMP] pos/payment-methods: Update "Payment methods" doc [IMP] POS: Update "Payment methods" doc Oct 7, 2025
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this much-needed update @emmi-odoo! 🙏 As usual, please reach out if anything unclear or needs discussing!

Comment on lines 35 to 38
- If the :doc:`Urban Piper </applications/sales/point_of_sale/online_food_delivery>` setting is
enabled in the :ref:`POS settings <configuration/settings>`, the :guilabel:`Delivery Payment`
option appears on the :guilabel:`Payment Method` form and is used for online delivery payments.
Select a :guilabel:`Delivery Provider` to configure the option.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not super clear to me the link between UrbanPiper and payment methods (sorry!) Could we please discuss this?

Comment on lines 39 to 43
- If the Accounting app is installed, the :guilabel:`Outstanding Account` and
:guilabel:`Intermediary Account` options appear in the :guilabel:`Payment Method` form to
assign transactions to different :doc:`accounts
</applications/finance/accounting/get_started/chart_of_accounts>`. Leave the field empty to
use the company's default account.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There is no mention of intermediary accounts anywhere in the accounting doc; what is it exactly? just an account receivable used specifically for that payment method (instead of the general POS)
  • I think you can only select an oustanding account if you select a journal (which makes sense because outstanding accounts are used (amongst other things) to create journal entries.
  • I don't think you can always set both types of accounts; sometimes it's one or the other. Also, when can you set both actually? when would that make sense?
  • I'm not sure about the Chart of accounts doc link, could ther ebe a more useful doc link maybe? (let's talk to the accounting people about this!)
Suggested change
- If the Accounting app is installed, the :guilabel:`Outstanding Account` and
:guilabel:`Intermediary Account` options appear in the :guilabel:`Payment Method` form to
assign transactions to different :doc:`accounts
</applications/finance/accounting/get_started/chart_of_accounts>`. Leave the field empty to
use the company's default account.
- If the Accounting app is installed, the :guilabel:`Outstanding Account` (if a :guilabel:`Journal` is set) and/or
:guilabel:`Intermediary Account` fields can be used to record the transactions made with the payment method in different :doc:`accounts <change this link?s>`. Leave the fields empty to use the company's default account.

and where is the default account set? is this described somewhere in the pos doc?

@emmi-odoo emmi-odoo force-pushed the saas-18.4-pos-payment-methods-emmi branch from 3db7ff4 to 141b558 Compare October 13, 2025 08:11
@emmi-odoo
Copy link
Contributor Author

Hello @auva-odoo ,

The comments have been implemented, and the parts on Urban Piper as well as Intermediary/Outstanding Account have been improved. Thanks again for the review.

@emmi-odoo emmi-odoo requested a review from auva-odoo October 13, 2025 08:34
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @emmi-odoo! i added a few more comments and suggestions!

@emmi-odoo emmi-odoo force-pushed the saas-18.4-pos-payment-methods-emmi branch from 141b558 to 700f49b Compare October 13, 2025 12:20
@emmi-odoo emmi-odoo requested a review from auva-odoo October 13, 2025 12:49
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @emmi-odoo !

@robodoo r+

robodoo pushed a commit that referenced this pull request Oct 14, 2025
task-4946924

closes #14783

Signed-off-by: Audrey Vandromme (auva) <auva@odoo.com>
@robodoo robodoo closed this Oct 14, 2025
@emmi-odoo emmi-odoo removed the request for review from a team October 22, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants